[ntuple] Add a common RNTupleOpenSpec
#16653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
approved these changes
Oct 11, 2024
| std::string fStorage; | ||
| RNTupleReadOptions fOptions; | ||
|
|
||
| RNTupleOpenSpec() = default; |
There was a problem hiding this comment.
Also add rule of five methods
There was a problem hiding this comment.
I have to correct myself here, the default constructor is not involved with the rule of five, so actually it would be better to not write any other of the special methods in the class. Apologies for the confusion!
Test Results 17 files 17 suites 3d 23h 14m 46s ⏱️ For more details on these failures, see this check. Results for commit 313445a. ♻️ This comment has been updated with latest results. |
enirolf
force-pushed
the
ntuple-openspec
branch
4 times, most recently
from
d0722a6
to
8ee2533
Compare
The specification structs `RNTupleReader::ROpenSpec` and `RNTupleSourceSpec` (used by `RNTupleProcessor`) are virtually identical, so it makes no sense to keep both around.
enirolf
force-pushed
the
ntuple-openspec
branch
from
8ee2533
to
313445a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification structs
RNTupleReader::ROpenSpecandRNTupleSourceSpec(used byRNTupleProcessor) are virtually identical, so it makes no sense to keep both around. This PR adds a commonRNTupleOpenSpec(other naming suggestions welcome of course) toRNTupleUtilthat can be used by bothRNTupleReader::OpenFriendsand theRNTupleProcessor.